-
Notifications
You must be signed in to change notification settings - Fork 355
refactor: add time range for jager get operations API #5791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
af182b4
to
9cda2f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. And I think we can use a generic header to limit time range for all metadata APIs.
1de5f50
to
0e82862
Compare
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
The native Jaeger query API doesn't have a parameter to limit the time range for getting operations(span) for a specific service. When the trace table gets larger, its performance will be terrible.
In this PR, I add the http header
x-greptime-jaeger-time-range-for-operations
to add a time range explicitly. For example:We don't add the time range by default and let the user configure it based on their scenarios.
PR Checklist
Please convert it to a draft if some of the following conditions are not met.