Skip to content

Conversation

@SNC123
Copy link
Contributor

@SNC123 SNC123 commented Sep 26, 2025

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

#6756 (Tracking Issue)

What's changed and what's your intention?

As title. 🐭
Implemented three build types for async index build:

  • Flush: Triggered after a flush operation.
  • Compact: Triggered after compaction if new files are created.
  • SchemaChange: Triggered by a schema change when a fast-path index build is required.
  • Manual: Triggered manually by an administrator via the build_index('table_name') function. (In another PR)

PR Checklist

Please convert it to a draft if some of the following conditions are not met.

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.
  • API changes are backward compatible.
  • Schema or data changes are backward compatible.

@github-actions github-actions bot added size/XL docs-not-required This change does not impact docs. labels Sep 26, 2025
@SNC123 SNC123 force-pushed the feat/async_index_build_types branch from 1c7fae6 to bb0dad5 Compare October 11, 2025 13:32
@github-actions github-actions bot added size/L and removed size/XL labels Oct 11, 2025
@SNC123 SNC123 force-pushed the feat/async_index_build_types branch from 1c42594 to cbb8a12 Compare October 13, 2025 10:42
@SNC123 SNC123 marked this pull request as ready for review October 14, 2025 05:57
@SNC123 SNC123 requested review from a team, evenyag, v0y4g3r and waynexia as code owners October 14, 2025 05:57
@SNC123 SNC123 mentioned this pull request Oct 14, 2025
3 tasks
@evenyag evenyag requested a review from zhongzc October 14, 2025 07:02
@github-actions github-actions bot added size/M and removed size/L labels Oct 14, 2025
@SNC123 SNC123 changed the title feat: implement four build types for async index build feat: implement three build types for async index build Oct 14, 2025
Signed-off-by: SNC123 <[email protected]>
Copy link
Collaborator

@zhongzc zhongzc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others look good to me.

@evenyag evenyag added this pull request to the merge queue Oct 21, 2025
Merged via the queue into GreptimeTeam:main with commit a1af4dc Oct 21, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-not-required This change does not impact docs. size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants