feat: gc worker heartbeat instruction #7118
Open
+800
−130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
discord9
requested review from
a team,
MichaelScofield,
evenyag,
v0y4g3r and
waynexia
as code owners
github-actions
bot
added
size/M
docs-not-required
Signed-off-by: discord9 <[email protected]>
Signed-off-by: discord9 <[email protected]>
discord9
force-pushed
the
feat/gc_hb_instr
branch
from
fa0c303 to
deaf5d5
Compare
Signed-off-by: discord9 <[email protected]>
Comment on lines
+346
to
+358
| pub fn into_extensions(&self, extensions: &mut std::collections::HashMap<String, Vec<u8>>) { | ||
| let bytes = serde_json::to_vec(self).unwrap_or_default(); | ||
| extensions.insert(Self::GC_STAT_KEY.to_string(), bytes); | ||
| } | ||
|
|
||
| pub fn from_extensions( | ||
| extensions: &std::collections::HashMap<String, Vec<u8>>, | ||
| ) -> Option<Self> { | ||
| extensions | ||
| .get(Self::GC_STAT_KEY) | ||
| .and_then(|bytes| serde_json::from_slice(bytes).ok()) | ||
| } | ||
| } |
There was a problem hiding this comment.
How's the safety to ignore the serde errors(using default and none)?
| get_file_refs: GetFileRefs, | ||
| ) -> Option<InstructionReply> { | ||
| let region_server = self.region_server; | ||
| info!("Getting mito Engine"); |
There was a problem hiding this comment.
seems like a meaningless log
| error: Some("MitoEngine not found".to_string()), | ||
| })); | ||
| }; | ||
| info!( |
There was a problem hiding this comment.
Suggested change
| info!( | |
| debug!( |
| gc_regions: GcRegions, | ||
| ) -> Option<InstructionReply> { | ||
| let region_ids = gc_regions.regions.clone(); | ||
| info!("Received gc regions instruction: {:?}", region_ids); |
There was a problem hiding this comment.
Suggested change
| info!("Received gc regions instruction: {:?}", region_ids); | |
| debug!("Received gc regions instruction: {:?}", region_ids); |
| let region_ids = gc_regions.regions.clone(); | ||
| info!("Received gc regions instruction: {:?}", region_ids); | ||
|
|
||
| let mut table_id = None; |
There was a problem hiding this comment.
Seems this table_id is useless?
| | ParseAddr { .. } | ||
| | TomlFormat { .. } => StatusCode::InvalidArguments, | ||
| | TomlFormat { .. } | ||
| | InvalidGcArgs { .. } => StatusCode::InvalidArguments, |
There was a problem hiding this comment.
I remember InvalidArguments is for hinting user. But InvalidGcArgs is produced by us, so it should be "internal".
|
|
||
| #[snafu(display("Failed to run gc for mito engine"))] | ||
| GcMitoEngine { | ||
| region_id: RegionId, |
There was a problem hiding this comment.
this should be presented in the error message, otherwise why carry it
| ref_files.extend(files); | ||
| } | ||
| } | ||
| info!("Unfiltered ref files: {:?}", ref_files); |
There was a problem hiding this comment.
Suggested change
| info!("Unfiltered ref files: {:?}", ref_files); | |
| debug!("Unfiltered ref files: {:?}", ref_files); |
There was a problem hiding this comment.
please check other places that info logs are too verbose
| .iter() | ||
| .filter(|file_id| !in_use_filenames.contains(*file_id)) | ||
| .copied() | ||
| .copied() |
There was a problem hiding this comment.
why copy twice
Suggested change
| .copied() |
| /// ``` | ||
| #[derive(Default, Clone, Copy, PartialEq, Eq, PartialOrd, Ord, Hash, Serialize, Deserialize)] | ||
| pub struct RegionId(u64); | ||
| pub struct RegionId(#[serde(deserialize_with = "str_or_u64")] u64); |
There was a problem hiding this comment.
When is region id being serialized as string at the first place?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
as title, related instructions for running gc worker
PR Checklist
Please convert it to a draft if some of the following conditions are not met.