feat: reloadable tls client config #7230
Open
+411
−118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/M
docs-not-required
shuiyisong
force-pushed
the
feat/reload_tls_in_gRPC_client
branch
from
caf3366 to
cfcf157
Compare
shuiyisong
requested review from
a team,
waynexia and
zhongzc
as code owners
evenyag
requested review from
MichaelScofield
and removed request for
zhongzc
| pub fn maybe_watch_server_tls_config( | ||
| tls_server_config: Arc<ReloadableTlsServerConfig>, | ||
| ) -> Result<()> { | ||
| common_grpc::reloadable_tls::maybe_watch_tls_config(tls_server_config, || {}).map_err(|e| { |
Collaborator
There was a problem hiding this comment.
If server TLS config is changed, do we need to proactively close all connected client channels?
Contributor
Author
There was a problem hiding this comment.
The newly request would be served using the new TLS config in MySQL and PG, but the connected/alive connection stays unaffected. What do you think, should we actively close the connection to force refresh TLS change? @sunng87
fengys1996
reviewed
Nov 19, 2025
| info!("Spawning background task for watching TLS cert/key file changes"); | ||
| std::thread::spawn(move || { | ||
| let _watcher = watcher; | ||
| while let Ok(res) = rx.recv() { |
Contributor
There was a problem hiding this comment.
nit: Should we ignore the error here? Or add log
Signed-off-by: shuiyisong <[email protected]>
Signed-off-by: shuiyisong <[email protected]>
Signed-off-by: shuiyisong <[email protected]>
Signed-off-by: shuiyisong <[email protected]>
Signed-off-by: shuiyisong <[email protected]>
Signed-off-by: shuiyisong <[email protected]>
Signed-off-by: shuiyisong <[email protected]>
Signed-off-by: shuiyisong <[email protected]>
Signed-off-by: shuiyisong <[email protected]>
shuiyisong
force-pushed
the
feat/reload_tls_in_gRPC_client
branch
from
bfdaeda to
1e60e34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
This patch introduces the ability for
channel_managerto use a re-loadable client TLS config to automatically reload the TLS files when changed.The
ReloadableTlsServerConfigis now extracted intoreloadable_tlsfor reuse.PR Checklist
Please convert it to a draft if some of the following conditions are not met.