fix: remove base image styles in favor of emptydata styles #712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the image styling approach by removing global base styles for images and pictures, moving the specific styles to the EmptyData component where they are actually needed. This reduces the global CSS footprint and makes the styling more intentional and maintainable.
- Removed global
imgandpicturestyles from the base stylesheet - Added a scoped
.imageclass toEmptyData.module.scsswith the same styles - Applied the new
.imageclass to the magnifying glass image in the EmptyData component
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/styles/_Base.scss | Removed global image and picture styles |
| src/components/Common/EmptyData/EmptyData.tsx | Added className prop to apply scoped image styles |
| src/components/Common/EmptyData/EmptyData.module.scss | Added new .image class with the previously global styles |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jeffredodd
requested review from
dmortal,
krisxcrash,
serikjensen and
shermango
shermango
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pr removes our base img/picture style and implemented the style directly in the one place its used today.