Repository 구조 변경 #138
Open
Repository 구조 변경 #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onetuks
requested changes
Jan 11, 2024
Contributor
onetuks
left a comment
onetuks
left a comment
There was a problem hiding this comment.
어지러운 구조가 정리되니까 훨씬 보기 좋네요!!
고생하셨습니다
Has a 관계를 생각하지 않고 instance of 만 생각했던게 지난 구조의 패착이었나보네요
병합충돌 있어서 일단 리뷰만 남겼습니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
그림과 같이 구조 변경
하면서 느낀 점
커스텀 메서드가 누락되는 것을 알기 힘들기에 이전 구조는 위험한 것 같다.