Skip to content

Fix: Correct invalid YAML syntax in add_external_models.sh template #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: Correct invalid YAML syntax in add_external_models.sh template #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions scripts/add_external_models.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@ set -e

if [ -n "$COMFYUI_INSTALLER_DIR" ]; then
if [ -f ".settings" ]; then
pirntf "source [\033[0;32m.settings\033[m]"
printf "source [\033[0;32m.settings\033[m]\n"
source .settings
elif [ -f "scripts/.settings" ]; then
printf "source [\033[0;32mscripts/.settings\033[m]"
printf "source [\033[0;32mscripts/.settings\033[m]\n"
source scripts/.settings
else
printf "[!] No settings file found. Please run the setup script first."
printf "[!] No settings file found. Please run the setup script first.\n"
exit 1
fi
sleep 1
Expand All @@ -28,7 +28,7 @@ EXTRA_MODELS() {
printf "[!] [\033[0;32mExtra Model Paths\033[m] file found, creating backup.\n"
cp "$COMFYUI_DIR/extra_model_paths.yaml" "$COMFYUI_DIR/extra_model_paths.yaml.bak"
fi
cat <<EOF >>"$COMFYUI_DIR/extra_model_paths.yaml"
cat <<EOF >"$COMFYUI_DIR/extra_model_paths.yaml"
comfyui:
base_path: $EXTERNAL_MODELS_DIR
# You can use is_default to mark that these folders should be listed first, and used as the default dirs for eg downloads
Expand All @@ -38,8 +38,10 @@ comfyui:
clip_vision: models/clip_vision/
configs: models/configs/
controlnet: models/controlnet/
diffusion_models: |
models/diffusion_models
# --- FIX ---
# The previous multi-line definition for 'diffusion_models' was incorrect
# and caused a YAML syntax error. It has been corrected to a single line.
diffusion_models: models/diffusion_models/
lora: models/lora/
upscale_models: models/upscale_models/
vae: models/vae/
Expand Down