fix(browser): parse DOMShell structured fields for ls and grep - #379
Open
cat0825 wants to merge 1 commit into
Open
fix(browser): parse DOMShell structured fields for ls and grep#379cat0825 wants to merge 1 commit into
cat0825 wants to merge 1 commit into
Conversation
cat0825
requested review from
omerarslan0,
yuh-yang and
zhangxilong-43
as code owners
July 8, 2026 06:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes multiple DOMShell parsing issues introduced in the 2.x migration, addressing both
lsandgrepformats._parse_execute_resultforlsto extractname,role, andpathproperly, enabling correct JSON round-tripping for follow-up fs commands._parse_execute_resultforgrepto extract structured fields and adds logic inbrowser_cli.pyto neatly display these elements rather than raw string matching.Fixes #342
Fixes #316
Type of Change
For Existing CLI Modifications
python3 -m pytest cli_anything/<software>/tests/test_core.py -vpython3 -m pytest cli_anything/<software>/tests/test_full_e2e.py -vregistry.jsonentry is updated if version, description, or requirements changedGeneral Checklist
--jsonflag is supported on any new commandsfeat:,fix:,docs:,test:)Test Results