Refactor some digitransit library code #5585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vesameskanen
commented
Dec 2, 2025
vesameskanen
commented
- Icon component always rendered all (almost 100) icons when only one was needed, fixed
- Better IO error tolerance in search
Also, provide a default icon.
Broken datasource or IO errors can inject null/undefined entries. Also, trust that item properties always exists.
hjvuor
requested changes
Dec 2, 2025
digitransit-search-util/packages/digitransit-search-util-helpers/index.js
Outdated
Show resolved
Hide resolved
partisaani
reviewed
Dec 2, 2025
digitransit-search-util/packages/digitransit-search-util-helpers/index.js
Show resolved
Hide resolved
partisaani
reviewed
Dec 2, 2025
Contributor
partisaani
left a comment
partisaani
left a comment
There was a problem hiding this comment.
Left a note on weird Array.prototype.filter call
Member
Author
|
Let's wait until tomorrow before merging this, to allow some dev testing time. We had to do many releases because of route page bugs, the same may happen again tomorrow. |
partisaani
approved these changes
Dec 3, 2025
hjvuor
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.