Skip to content

Add devcontainer build env#3277

Merged
ethouris merged 1 commit into
Haivision:devfrom
fujitatomoya:add-devcontainer-build-env
Feb 25, 2026
Merged

Add devcontainer build env#3277
ethouris merged 1 commit into
Haivision:devfrom
fujitatomoya:add-devcontainer-build-env

Conversation

@fujitatomoya
Copy link
Copy Markdown
Contributor

@fujitatomoya fujitatomoya commented Jan 26, 2026

part of #3265, and replaces #3275

this still requires codespell script that is expected to be issued by user.

@fujitatomoya fujitatomoya changed the base branch from master to dev January 26, 2026 02:26
@@ -0,0 +1,100 @@
# Building SRT Using Devcontainer or Docker
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i confirmed and verified the all following procedure.

just FYI, when we open the devcontainer via vscode 1st time, it will need to build to container image. so it takes a minutes to build the docker image for devcontainer. but from the 2nd time to open the devcontainer, it just binds the environment to the already-built image, so i does not take any time to start.

Comment thread README.md
## Build Instructions

[Linux (Ubuntu/CentOS)](./docs/build/build-linux.md) | [Windows](./docs/build/build-win.md) | [macOS](./docs/build/build-macOS.md) | [iOS](./docs/build/build-iOS.md) | [Android](./docs/build/build-android.md) | [Package Managers](./docs/build/package-managers.md)
[Linux (Ubuntu/CentOS)](./docs/build/build-linux.md) | [Windows](./docs/build/build-win.md) | [macOS](./docs/build/build-macOS.md) | [iOS](./docs/build/build-iOS.md) | [Android](./docs/build/build-android.md) | [Package Managers](./docs/build/package-managers.md) | [Devcontainer/Docker](./docs/build/build-devcontainer.md)
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we talked about this is optional procedure, i added this procedure in the last.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya fujitatomoya force-pushed the add-devcontainer-build-env branch from 96d70e3 to 3627352 Compare January 26, 2026 02:43
@ethouris
Copy link
Copy Markdown
Collaborator

Just a question: what are requirements for the file location of the devcontainer configuration and the docker?

Can they be freely moved elsewhere?

@@ -0,0 +1,19 @@
{
"name": "SRT Development",
"dockerFile": "../docker/Dockerfile",
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ethouris .devcontainer/devcontainer.json needs to be statically there, and docker file is linked as relative path. to answer your question, no we cannot move those files freely. and i am not quite sure why this is a hard requirement... if that is we can never use the devcontainer or codespace...

@fujitatomoya
Copy link
Copy Markdown
Contributor Author

@ethouris after the discussion with you, i changed the title on this issue. let's keep this to enable devcontainer environment for developers. i think this also makes a lot of sense for the dev env in these days to welcome developers and engineers.

@ethouris ethouris added this to the v1.6.0 milestone Feb 5, 2026
@ethouris ethouris added Type: Enhancement Indicates new feature requests [build] Area: Changes in build files labels Feb 5, 2026
@fujitatomoya
Copy link
Copy Markdown
Contributor Author

@ethouris friendly ping! is there anything needs to be done on my side? if that is so, please do not hesitate to do that 😄

@ethouris ethouris merged commit 40b4dfa into Haivision:dev Feb 25, 2026
14 of 15 checks passed
@ethouris
Copy link
Copy Markdown
Collaborator

Alright, just note that it is merged to "dev" branch. The 1.5.5 release is not out yet and more stability tests will have to be conducted on the "dev" branch before - after the release of course - it will become the new "master".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[build] Area: Changes in build files Type: Enhancement Indicates new feature requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants