Allow empty partial-block #606
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I authored a partial-template with optional block-includes and happened to write
{{#>mail}}{{/mail}}for the test-mail, as I did not need to adjust the optionals. This led to an exception similar to the one below:Being new to Handlebars.Net it took me a while to understand what really was wrong. I no know, that I can change the template to
{{>mail}}, but the exception isn't really helpful and I don't know why it shouldn't just render. So this pull-request allows block-includes with empty blocks.On a side-note
{{#>mail}}{{/mail}}renders, if nomail-partial is present, while{{>mail}}throws an exception, if noMissingPartialTemplateHandleris registered. While not necessary for my use-case it may even be nice to have a syntax, that allows for optional partials out-of-the-box.