Change OpenGL textures array to vector, and double texture cache#6249
Open
garrettjoecox wants to merge 1 commit intoHarbourMasters:developfrom
Open
Change OpenGL textures array to vector, and double texture cache#6249garrettjoecox wants to merge 1 commit intoHarbourMasters:developfrom
garrettjoecox wants to merge 1 commit intoHarbourMasters:developfrom
Conversation
Pepper0ni
approved these changes
Feb 11, 2026
Contributor
Pepper0ni
left a comment
Pepper0ni
left a comment
There was a problem hiding this comment.
Gave it a quick test and it fixed my issues 🥳
Contributor
|
How should I test to try to break it? |
Contributor
|
@Malkierian I think enough other people have run into this & had this fix it that we can say it's good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DirectX & Metal were already using vectors for this array, OpenGL had it at a static size which we overflowed due to loading +524 textures for ImGui (
LoadGuiTexture) + 500 in game textures (TEXTURE_CACHE_MAX_SIZE) > 1024Would like someone to verify on DirectX, OpenGL & Metal that the cache doubling doesn't break anything. (Hopefully should improve perf by a tiny amount)
LUS PR
Build Artifacts