Din's Fire cutscene skip#6273
Open
johnlauhansen wants to merge 3 commits intoHarbourMasters:developfrom
Open
Conversation
Rename of Function and add summaries
Rename of Function and add summaries
…en/Shipwright into feat/DinFireEnhanced
serprex
reviewed
Feb 16, 2026
| /// </summary> | ||
| /// <param name="itemAction">item used</param> | ||
| /// <returns>True: cutscene is skipped</returns> | ||
| bool IsCutsceneSkipped(s8 itemAction) { |
Contributor
There was a problem hiding this comment.
should be handled by time saver hooks
Author
There was a problem hiding this comment.
Hi thanks for the review. I'll commit corrections when I've a moment.
serprex
reviewed
Feb 16, 2026
| /// Check if the current item used has its cutscene skipped in the settings of soh | ||
| /// Enhancements => Items | ||
| /// </summary> | ||
| /// <param name="itemAction">item used</param> |
serprex
reviewed
Feb 16, 2026
| /// </summary> | ||
| /// <param name="play">state of play</param> | ||
| /// <param name="camSetting">camera state to set</param> | ||
| void Camera_ChangeFocus(PlayState* play, s16 camSetting) { |
Contributor
There was a problem hiding this comment.
decomp renamed this to Player_RequestCameraSetting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added an option in SoH Enhancement => Items => Magic spells to remove the cutscene (change of position camera) when Din's fire is used. I've prepared the code to add more cutscenes skip for other item (bottle, Fazrore, Nayru etc...)
I've renamed some function names and added some summaries to explain this part of the code.
Build Artifacts