Hookify Hookshot Reticle Changes#6279
Hookify Hookshot Reticle Changes#6279A-Green-Spoon wants to merge 1 commit intoHarbourMasters:developfrom
Conversation
| static RegisterShipInitFunc initFunc(RegisterTargetableHookshotReticle, | ||
| { CVAR_ENHANCEMENT("HookshotableReticle"), | ||
| CVAR_COSMETIC("HookshotReticle.NonTarget.Value") }); No newline at end of file |
There was a problem hiding this comment.
| static RegisterShipInitFunc initFunc(RegisterTargetableHookshotReticle, | |
| { CVAR_ENHANCEMENT("HookshotableReticle"), | |
| CVAR_COSMETIC("HookshotReticle.NonTarget.Value") }); | |
| static RegisterShipInitFunc initFunc(RegisterTargetableHookshotReticle, | |
| { CVAR_TARGETABLE_HOOKSHOT_NAME, | |
| CVAR_NON_TARGETABLE_HOOKSHOT_NAME }); |
& then maybe don't need ShipInit::Init call you added
There was a problem hiding this comment.
Good idea, hadn't tried this combo, yet, but no dice. I need the value in there regardless because the color picker change fires off a shipinit, but still isn't firing on just the cosmetic name for a reset.
There was a problem hiding this comment.
note initFunc cvars are supposed to list the dependencies for shouldRegister, what's used inside the hook is dynamic. ie even if this suggestion doesn't work, it's at least more technically correct
makes sense re still needing shipinit call
There was a problem hiding this comment.
I agree - .changed was convenient for the bool, but it won't fire shipinit. I could instead check shouldRegister on .value = default so that they match?
2 participants
Moves the targetable hookshot reticle and regular reticle color change to a hook, restoring the source that was changed to accommodate the enhancements. I did not revert the variable name changes, but could.
For this to revert to the vanilla path properly, I added a shipinit call on the reset color button - eyes on this specifically would be good because it's the part I'm least familiar with.
Build Artifacts