Add fixed mode for CMC

[f1ana]

Adds a fixed mode for CMC, where only the item category is considered.
This differs from adaptable, previously the on setting, where downgrading to lesser is possible depending on inventory.
If you have had this CMC selected in prior builds, you'll see adaptable selected, so it should be back compat friendly.

Build Artifacts

• soh-linux.zip
• soh-windows.zip
• soh-mac.zip

[A-Green-Spoon]

Suggested change

	"Categories: Major items, Lesser items, Junk items, Small keys, Boss keys, Skulltula Tokens."));
	"Categories: Major items, Lesser items, Junk items, Small keys, Boss keys, Skulltula Tokens, Pieces of Heart."));

[A-Green-Spoon]

While we're in here, should've been added previously

[f1ana]

All set. Also rebased for good measure.

[Pepper0ni]

24-67-36-99-76.json
This doesn't seem to work for stick upgrades in grass at minimum, as those reverted to lesser even in fixed mode. I attached a seed with 2 stick upgrades in lake hylia grass to demonstrate

[f1ana]

24-67-36-99-76.json
This doesn't seem to work for stick upgrades in grass at minimum, as those reverted to lesser even in fixed mode. I attached a seed with 2 stick upgrades in lake hylia grass to demonstrate

Thanks, I'll check it out. I tested with chests and it seemed fine. Maybe grass doesn't use that helper.

[f1ana]

This ended up being a category resolution issue upstream from the helper. Stick upgrades were being downgraded to lesser and processed as-is from the adjustment helper.
I'm not crazy about having two sites in which we're adjusting category. Would be nice to consolidate those in a future effort if possible.

[Pepper0ni]

35-92-46-17-07.json
Found another failed conversion, this time a bean soul pot in BotW being junk even on fixed when I already have the bean soul.

[f1ana]

35-92-46-17-07.json Found another failed conversion, this time a bean soul pot in BotW being junk even on fixed when I already have the bean soul.

Shuffle Bean Souls is off in this spoiler, is there a different one that I can peek at?
Does this also mean that you had plentiful items on, since it sounds like you're referring to the same soul? If so, wouldn't this mean that you would hit CANT_OBTAIN_ALREADY_HAVE from the obtainability check?
Sorry if I'm missing the point, just trying to figure out what to do next.

[Pepper0ni]

oops, wrong file, I have too many folders with spoilers, meant this one
38-44-10-90-63.json
And yes I was testing with plentiful items specifically to check for this eventuality, my understanding is fixed mode would retain the original item's rarity for CMC even if it's made a bluepee by CANT_OBTAIN_ALREADY_HAVE.

[f1ana]

oops, wrong file, I have too many folders with spoilers, meant this one 38-44-10-90-63.json And yes I was testing with plentiful items specifically to check for this eventuality, my understanding is fixed mode would retain the original item's rarity for CMC even if it's made a bluepee by CANT_OBTAIN_ALREADY_HAVE.

Ah, I see what you're saying. I guess the description in the UI is a bit open ended. I viewed it as a means to prevent downgrading majors to lessers, but yeah what you're describing makes sense too. I'll make that change

[f1ana]

Made the change and rebased. Tested a plando locally with two mirror shields at Mido's house.
Both chests stayed gold and the neither one skipped the animation, despite one being a bluepee.