Fix startup crash from over-long "Speak Hylian" stat name - #6995
Open
bassdr wants to merge 1 commit into
Open
Conversation
itemTimestampDisplayName rows are char[24], sized for the 23-char column the table uses. HarbourMasters#6978 corrected "SpeakHylian:" to "Speak Hylian:" but kept the original padding, making the string 24 chars + NUL = 25 bytes. That overflows the buffer, so the strcpy in SetupDisplayNames aborts (__strcpy_chk) at GUI init on any _FORTIFY_SOURCE build, crashing before the main menu. Drop one trailing space to restore the 23-char column. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
A-Green-Spoon
approved these changes
Jul 29, 2026
Contributor
Author
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Booting aborts before the main menu on any
_FORTIFY_SOURCEbuild:Cause
itemTimestampDisplayNamerows arechar[24], sized for the 23-character column the rest of the table uses. #6978 corrected the typo"SpeakHylian:"->"Speak Hylian:"but kept the original trailing padding, so the string became 24 chars + NUL = 25 bytes and overflows its buffer.strcpythen aborts via__strcpy_chkduring GUI init. Unfortified builds overrun by one byte silently and still boot, which is why CI didn't catch it.Fix
Drop one trailing space so the entry is back to the 23-character column (matching
"Speak Kokiri:","Speak Goron:", etc.). No other row exceeds 23 characters.🤖 Generated with Claude Code
Build Artifacts