fix: Preserve tray tooltip when showing notifications#239
Merged
HavenDV merged 1 commit intoMay 15, 2026
Merged
Conversation
Include the current tooltip fields in the same NIM_MODIFY call that displays a native balloon notification. Explorer can otherwise treat an immediate post-create NIF_INFO update as replacing the newly-added icon state and stop showing the hover tooltip until the tooltip is written again. This keeps the existing UseStandardTooltip behavior by carrying NIF_SHOWTIP through notification updates, and sends NIF_TIP with the current cached tooltip text for both 32-bit and 64-bit NOTIFYICONDATA paths. No public API surface changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a regression where setting
ToolTipTextbeforeForceCreate()can be lost as the visible hover tooltip ifShowNotification(...)is called immediately after the tray icon is created.Repro
Then try hovering the tray icon.
Codex explanation
The tooltip is assigned before
ForceCreate(), andCreate()sends it toShell_NotifyIconwithNIF_TIP. The problem is the immediately following notification update:ShowNotification(...)sends anotherNIM_MODIFYwithNIF_INFO, but previously did not include the current tooltip fields. Explorer can then stop showing the hover tooltip until the tooltip is written again.This change preserves the current tooltip state during the notification modify call by sending the cached tooltip text with
NIF_TIP, and carryingNIF_SHOWTIPwhenUseStandardTooltipis enabled.