Skip to content

[SemVer] Reflect.compare() is not specified to return exactly 1 or -1… #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kLabz wants to merge 2 commits into
base: development
Choose a base branch
from
Open

[SemVer] Reflect.compare() is not specified to return exactly 1 or -1… #682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f436bc8
[SemVer] Reflect.compare() is not specified to return exactly 1 or -1…
kLabz Dec 2, 2025
4a9082d
[tests] Add comparison tests
kLabz Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/haxelib/SemVer.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,16 +110,16 @@ abstract SemVer(String) to String {
return isValid(this);

@:op(a > b) static inline function gt(a:SemVer, b:SemVer)
return compare(a, b) == 1;
return compare(a, b) > 0;

@:op(a >= b) static inline function gteq(a:SemVer, b:SemVer)
return compare(a, b) != -1;
return compare(a, b) >= 0;

@:op(a < b) static inline function lt(a:SemVer, b:SemVer)
return compare(a, b) == -1;
return compare(a, b) < 0;

@:op(a <= b) static inline function lteq(a:SemVer, b:SemVer)
return compare(a, b) != 1;
return compare(a, b) <= 0;

@:op(a == b) static inline function eq(a:SemVer, b:SemVer)
return compare(a, b) == 0;
Expand Down
11 changes: 11 additions & 0 deletions test/tests/TestSemVer.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,17 @@ class TestSemVer extends TestBase {
assertEquals( "invalid", parseInvalid("10.50.2-rc.01"));
}

public function testPreviewComparison() {
assertTrue(SemVer.ofString("0.1.1-beta.1") < SemVer.ofString("0.1.1"));
assertTrue(SemVer.ofString("0.1.1-beta.1") > SemVer.ofString("0.1.0"));
assertTrue(SemVer.ofString("0.1.1-alpha.2") > SemVer.ofString("0.1.1-alpha.1"));
assertTrue(SemVer.ofString("0.1.1-beta.1") > SemVer.ofString("0.1.1-alpha.2"));
assertTrue(SemVer.ofString("0.1.1-rc.1") > SemVer.ofString("0.1.1-beta.1"));
#if !(server || haxelib_api)
assertTrue(SemVer.ofString("0.1.1-preview.1") > SemVer.ofString("0.1.1-rc.1"));
Copy link
Member

@tobil4sk tobil4sk Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the bug was specific to preview versions, on hashlink this was evaluating to false:

SemVer.ofString("1.2.2") < SemVer.ofString("1.2.4")

because the comparison returned -2

#end
}

function parseInvalid( str:String ):String {
return try {
SemVer.ofString(str);
Expand Down
Loading