Skip to content

Conversation

@MAJigsaw77
Copy link
Contributor

This PR improves how we check for ANSI color support by handling more terminals and CI environments and simplifying the detection logic in stripColor.

@Sword352
Copy link

image
Can confirm it works as excepted

@tobil4sk
Copy link
Member

tobil4sk commented Sep 1, 2024

Is it not possible to perform a more generic check for ansi color support? It's possible that these CI environments will change, or that not all environments are covered.

@MAJigsaw77
Copy link
Contributor Author

Is it not possible to perform a more generic check for ansi color support? It's possible that these CI environments will change, or that not all environments are covered.

This is best i could do, for CI they don't define TERM or anything else.

@MAJigsaw77
Copy link
Contributor Author

The best solution is to use these as of now.

@tobil4sk
Copy link
Member

tobil4sk commented Sep 2, 2024

What about adding a flag like HXCPP_COLOR, and then the scripts that install haxe in these ci environments can just make sure that is set?

@skial skial mentioned this pull request Sep 4, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants