Monitoring templates#42
Open
lenihan01 wants to merge 3 commits intoHewlettPackard:masterfrom
lenihan01:monitoring_templates
Open
Monitoring templates#42lenihan01 wants to merge 3 commits intoHewlettPackard:masterfrom lenihan01:monitoring_templates
lenihan01 wants to merge 3 commits intoHewlettPackard:masterfrom
lenihan01:monitoring_templates
Conversation
jofegan
requested changes
Oct 9, 2019
Contributor
jofegan
left a comment
jofegan
left a comment
There was a problem hiding this comment.
The basic patterns here are good and will work. I want to reorganize it a bit though, to fit better into the overall class hierarchy of this module. It will take me a day or two to draw up proper comments and direction.
Contributor
|
Status update: i have not been able to make time to refactor this PR yet. it's being trumped by higher priorities for the moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
o Added 2 new types to python-opsramp ; Metrics and Resources.
o Hooked these new classes into binding code.
o Added sample uses to retrieve monitors and metrics data.