Phone version handler and two little bits #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On systems that have both python 2 and 3, just calling python isn't good enough.
Move the debug protocol output to the function where we can produce the entire received message instead of just the payload.
Add a phone version endpoint handler so that we respond appropriately when connecting to a pebble. The pebble sends this query at the start of an RFCOMM connection and will assume a bare minimum of supported features if we don't respond. The only feature this controls (that I can tell) is whether or not the music app sends next/previous/pause commands back to us. Soo...this fixes the music app so that it actually works. Yay!
There was a problem hiding this comment.
Comparing to the pebble app's source, I'd by far prefer the following:
pack('!bi', 1, -1)
It makes it clear the magic value consists of two values rather than a single string - hopefully we can get Team Pebble to tell us what/why those values are there :)
sarfata
added a commit
to pebble/libpebble
that referenced
this pull request
Jul 3, 2013
Reference to log_levels need to be prefixed by 'self.'
I wrote these a long time ago but never pushed them. This lets libpebble shoot phone control messages at the pebble. I remember it worked at the time...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if the python2 thing will be broken on OS X or elsewhere, but it ends up using python 3 on my machine otherwise.
The phone version endpoint handler doesn't guess the current OS or anything because if you say you're anything but android you don't get music player messages anymore. I guess we're all android for now!