Add protocol version and encryption configuration to BroadcastService #2011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds initial support for protocol versioning and configurable encryption strategies to BroadcastService.
What was added
Added protocolVersion_ and encryptionStrategies_ internal fields with default values.
Allowed overriding these values through configuration (config.protocolVersion and config.encryptionStrategies).
Passed the protocol version and encryption strategy options to both CLink and SLink.
Added inline comments explaining the use of protocol versioning and encryption configuration.
Why this is useful
Prepares the broadcast system for future protocol upgrades.
Allows Puter instances to share protocol metadata through connection links.
Establishes a clean path for implementing stronger encryption or backward-compatible protocol changes.
Fully backward-compatible and does not affect existing behavior.
Compatibility
No breaking changes.
Extra fields passed to links are optional and safely ignored if unused.