Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review some docs #19265

Merged
merged 1 commit into from
Feb 8, 2025
Merged

Review some docs #19265

merged 1 commit into from
Feb 8, 2025
+22 −24

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Feb 8, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Part of Review and prune outdated docs #19214.
  • Most of these were fine still, apart from:
    • FAQ: hub is less maintained than gh.
    • Brew-Maintainer-Guide: link to GitHub docs on commit signing via GPG or SSH.
    • Interesting-Taps-and-Forks: remove outdated information about homebrew/core being in Library/Taps.
    • New-Maintainer-Checklist: remove outdated information about the @members team.

@issyl0
Review some docs
8f75f66 
- Most of these were fine still, apart from:
  - FAQ: `hub` is less maintained than `gh`.
  - Brew-Maintainer-Guide: link to GitHub docs on commit signing via GPG or SSH.
  - Interesting-Taps-and-Forks: remove outdated information about `homebrew/core` being in `Library/Taps`.
  - New-Maintainer-Checklist: remove outdated information about the `@members` team.
@issyl0 issyl0 enabled auto-merge February 8, 2025 14:49
p-linnane
p-linnane approved these changes Feb 8, 2025
View reviewed changes
Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these!

@issyl0 issyl0 added this pull request to the merge queue Feb 8, 2025
Merged via the queue into master with commit f9b33d7 Feb 8, 2025
28 checks passed
@issyl0 issyl0 deleted the review-some-docs branch February 8, 2025 16:15
@MikeMcQuaid
Copy link
Member

Thanks @issyl0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-linnane p-linnane p-linnane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@issyl0 @MikeMcQuaid @p-linnane