Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runme: update build and head to use correct org #212755

Merged
merged 2 commits into from
Mar 21, 2025

Conversation

sourishkrout
Copy link
Contributor

Using the runmedev org in the build instructions will make sure that commit hash and version numbers will be properly included in runme builds.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. go Go use is a significant feature of the PR or issue labels Mar 20, 2025
@sourishkrout sourishkrout force-pushed the master branch 2 times, most recently from 948131f to b6423d9 Compare March 20, 2025 23:50
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Mar 20, 2025
@nandahkrishna nandahkrishna changed the title Moved GitHub orgs since Runme is now part of the CNCF sandbox runme: update build and head to use correct org Mar 20, 2025
Copy link
Member

@nandahkrishna nandahkrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nandahkrishna nandahkrishna added the ready to merge PR can be merged once CI is green label Mar 20, 2025
Runme is now part of the CNCF sandbox.
This will fix the commit hash and version number in the Go build.
Also update the test to ensure that the version is reported correctly.

Signed-off-by: Sebastian (Tiedtke) Huckleberry <[email protected]>
Co-authored-by: Nanda H Krishna <[email protected]>
@chenrui333
Copy link
Member

Thanks @sourishkrout @nandahkrishna!

Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Mar 21, 2025
@BrewTestBot BrewTestBot enabled auto-merge March 21, 2025 01:25
@BrewTestBot BrewTestBot added this pull request to the merge queue Mar 21, 2025
Merged via the queue into Homebrew:master with commit ed1a561 Mar 21, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. go Go use is a significant feature of the PR or issue ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants