Open
Conversation
parse_config() needs to be called before write_config() due to #1476
hnyu
reviewed
Aug 15, 2023
| # for gin, we need to parse it first. Otherwise, configured.gin will be | ||
| # empty | ||
| common.parse_conf_file(conf_file) | ||
| common.parse_conf_file(conf_file) |
Collaborator
There was a problem hiding this comment.
Calling parse_conf_file in the main process will create an env, which might be unnecessary or even problematic in certain cases?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parse_conf_file() needs to be called before write_config() due to #1476