Skip to content
This repository was archived by the owner on Jan 9, 2023. It is now read-only.

build(deps): bump react bootstrap to v1.3.0 #585

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

build(deps): bump react bootstrap to v1.3.0 #585

wants to merge 15 commits into from

Conversation

jackcmeyer
Copy link
Member

Changes proposed in this pull request:

  • updates @fortawesome/fontawesome-svg-core
  • updates react-bootstrap
  • updates @types/react

@jackcmeyer jackcmeyer added the dependencies Pull requests that update a dependency file label Sep 10, 2020
@jackcmeyer jackcmeyer mentioned this pull request Sep 10, 2020
Closed
fox1t
fox1t previously approved these changes Sep 10, 2020
View reviewed changes
Copy link
Member

@fox1t fox1t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

matteovivona
matteovivona reviewed Sep 10, 2020
View reviewed changes
Copy link
Contributor

@matteovivona matteovivona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem to be going right :/ Build issue with Storybook (TS error)

blestab
blestab previously approved these changes Sep 16, 2020
View reviewed changes
Copy link

@blestab blestab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matteovivona
Copy link
Contributor

matteovivona commented Oct 7, 2020 •
edited
Loading

@HospitalRun/core-contributors can someone solve TS problems? Thanks!

@matteovivona matteovivona requested review from blestab, fox1t and matteovivona and removed request for morrme October 18, 2020 14:52
matteovivona
matteovivona reviewed Nov 15, 2020
View reviewed changes
Copy link
Contributor

@matteovivona matteovivona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not building

@CLAassistant
Copy link

CLAassistant commented Jan 30, 2021 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ tehKapa
❌ jackcmeyer
You have signed the CLA already but the status is still pending? Let us recheck it.

@baoqchau
Copy link

@tehkapa Does this issue still need to be worked on? If it does, can I try it?

@matteovivona matteovivona requested review from a team, cynthiachen7 and jameszheng405 and removed request for a team and blestab June 14, 2021 08:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@fox1t fox1t Awaiting requested review from fox1t

@jameszheng405 jameszheng405 Awaiting requested review from jameszheng405

@cynthiachen7 cynthiachen7 Awaiting requested review from cynthiachen7

2 more reviewers

@matteovivona matteovivona matteovivona left review comments

@blestab blestab blestab left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@fox1t fox1t

Labels

dependencies Pull requests that update a dependency file in progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jackcmeyer @matteovivona @CLAassistant @baoqchau @fox1t @blestab