All tasks completed #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshemsedinov
reviewed
Apr 8, 2020
| @@ -1,5 +1,6 @@ | |||
| 'use strict'; | |||
|
|
|||
| const hello = null; | |||
| const hello = name => console.log(`Hello ${name}!`); | |||
There was a problem hiding this comment.
Suggested change
| const hello = name => console.log(`Hello ${name}!`); | |
| const hello = name => { | |
| console.log(`Hello ${name}!`); | |
| }; |
| @@ -1,5 +1,6 @@ | |||
| 'use strict'; | |||
|
|
|||
| const hello = null; | |||
| const hello = name => console.log(`Hello ${name}!`); | |||
| // hello('Roman'); | |||
There was a problem hiding this comment.
Don't commit commented code
| @@ -1,5 +1,11 @@ | |||
| 'use strict'; | |||
|
|
|||
| const range = null; | |||
| const range = (start, end) => { | |||
| const array = []; | |||
There was a problem hiding this comment.
That's ok, but you can allocate array of predefined size with new Array(size)
| @@ -1,5 +1,11 @@ | |||
| 'use strict'; | |||
|
|
|||
| const rangeOdd = null; | |||
| const rangeOdd = (start, end) => { | |||
| const array = []; | |||
Comment on lines
+9
to
+10
| for (const person of phonebook) | ||
| return person.name === name ? person.phone : null; |
There was a problem hiding this comment.
Suggested change
| for (const person of phonebook) | |
| return person.name === name ? person.phone : null; | |
| for (const person of phonebook) { | |
| if (person.name === name) return person.phone; | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.