Skip to content

update CreateProjectPage.js#1309

Open
hrithikwins wants to merge 1 commit into
Hubs-Foundation:masterfrom
hrithikwins:projects-filter-fix
Open

update CreateProjectPage.js#1309
hrithikwins wants to merge 1 commit into
Hubs-Foundation:masterfrom
hrithikwins:projects-filter-fix

Conversation

@hrithikwins

Copy link
Copy Markdown

What?

When you promote a scene as 'featured' in admin panel it now shows up here.

Why?

Fixing bug #1308

Examples

image

How to test

  1. Go to 'demo.hubsfoundation.org'
  2. Click on 'New Project'
  3. Scroll down to 'Featured Projects'
  4. See 'The Featured projects'

Documentation of functionality

Limitations

Alternatives considered

Open questions

Additional details or related context

Fixed the query params for 'filtered-remix' to be show the 'featured' scenes
@DougReeder

Copy link
Copy Markdown
Member

Thanks! It's nice to squash these annoying bugs.

Unfortunately, I'm not seeing the fix. When I click to switch from All to Featured, the URL changes to https://demo.hubsfoundation.org/spoke/projects/create?filter=featured-remixable

If I manually edit the URL to https://demo.hubsfoundation.org/spoke/projects/create?filter=featured I do see the featured scenes.

Perhaps I'm running into a caching issue.

@Exairnous

Copy link
Copy Markdown
Member

Hi @hrithikwins
Thanks for the PR.

As far as I know, the featured tab on The New Project page should only show featured scenes that are also remixable (if it's not remixable, then you can't create a new project from it). This PR appears to switch it to display any scenes that are featured (regardless of whether they're remixable). While this appears to work, I believe it only sidesteps the problem. If you'll note, the "All" tab has a filter value of "remixable", so as far as I know the "Featured" tab should only show remixable content that is also featured (if the filter value is just featured, then it shows anything that is featured, whether or not it is remixable/can be used to create a new scene.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants