[Mozilla Branding Removal] Remove the last bits of Mozilla branding#1314
Open
Exairnous wants to merge 1 commit into
Open
[Mozilla Branding Removal] Remove the last bits of Mozilla branding#1314Exairnous wants to merge 1 commit into
Exairnous wants to merge 1 commit into
Conversation
What: Removes Mozilla branding from the habitat scripts, some test files, images, videos, and a few other miscellaneous files. Why: this is no longer a Mozilla project. Notes: The AVA test snapshot (test/integration/snapshots/Editor.test.js.snap) will need to be regenerated with `yarn run update-test-snapshots` due to the changes in test/integration/snapshots/Editor.test.js.md, but that will need to wait until the architecture kit and crater.glb are rehosted in order to complete successfully. Technically, this means one Mozilla reference is left (inside the snapshot), but it's only visible when running the tests and seeing it marked as an error. This doesn't remove/modify non branding related Mozilla references like credits or code/dependencies as that would be inappropriate/break things.
|
Thank you for the pull request. ROADMAP STATUS: This pull request isn't currently on any roadmap. Updates will be conveyed here as its place on/off a roadmap changes. You can view the roadmaps here: Roadmaps Google Drive folder. For more information on how the roadmaps work, see our roadmaps policy on GitHub. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Removes Mozilla branding from the habitat scripts, some test files, images, videos, and a few other miscellaneous files.
Why?
This is no longer a Mozilla project.
Examples
N/A
How to test
grep -r -i --exclude-dir={.git,.tersercache,dist,node_modules} "mozilla"find . -type f -exec file -N -i -- {} + | sed -n 's!: image/[^:]*$!!p'find . -type f -exec file -N -i -- {} + | sed -n 's!: video/[^:]*$!!p'Documentation of functionality
No functionality is changed, so no documentation update is needed.
Limitations
This doesn't regenerate the AVA test snapshot or fix the tests (technically it introduces a new test error). See the Additional details or related context section for why. It also doesn't fix the linter errors as these are unrelated to the branding removal.
Old URLs to previously Mozilla run servers, but without Mozilla in the name (e.g. something.reticulum.io), were left as it isn't necessarily clear what they should be replaced with (or they function as a reminder/placeholder for things we'll be rehosting in the future, like the architecture kit) and they don't directly reference Mozilla.
Alternative implementations considered
None.
Open questions
None.
Additional details or related context
The AVA test snapshot (test/integration/snapshots/Editor.test.js.snap) will need to be regenerated with
yarn run update-test-snapshotsdue to the changes in test/integration/snapshots/Editor.test.js.md, but that will need to wait until the architecture kit and crater.glb are rehosted in order to complete successfully. Technically, this means one Mozilla reference is left (inside the snapshot), but it's only visible when running the tests and seeing it marked as an error.This doesn't remove/modify non branding related Mozilla references like credits or code/dependencies as that would be inappropriate/break things.