Drop SaaS-setup mentions from speaker self-edit settings copy#256
Merged
Conversation
The admin-facing settings panel was leaking deployment-specific plumbing (the captcha host and the Firebase Trigger Email extension) into the in-app description. Self-edit is now backed by direct SMTP anyway, so the Trigger Email reference is also out of date. Keep the user-facing functional description (magic link, admin approval, 5 emails/speaker/day rate limit) and drop the infrastructure sentence — those concerns live in deploy docs, not the admin UI. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
HugoGresse
temporarily deployed
to
GitHub Action PR
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
Removes deployment-/infrastructure-specific wording from the admin “Speaker self-edit” settings panel copy so the UI only describes the end-user behavior (magic link, approval, rate limit) and avoids stale references to older email plumbing.
Changes:
- Trimmed the descriptive text to remove mentions of the captcha service URL and Firebase “Trigger Email” extension.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Visit the preview URL for this PR (updated for commit 68de607):
(expires Mon, 01 Jun 2026 16:03:48 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 0c15c45ea5a4c54095387eacf30c3755c9260f22 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The admin-facing speaker self-edit settings panel was leaking deployment-specific plumbing into the in-app description ("Requires the captcha service (captcha.openplanner.fr) and the Firebase 'Trigger Email' extension installed."). Self-edit is now backed by direct SMTP anyway, so the Trigger Email reference is also stale.
Trim to the user-facing functional description (magic link, admin approval, 5 emails/speaker/day rate limit). Infrastructure concerns belong in deploy docs.
Before / after
Before:
After:
Test plan
🤖 Generated with Claude Code