Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: OPTIC-1313: Reducing Toast usage in django templates to get rid of toast.min.js #6604

Open
wants to merge 47 commits into
base: develop
Choose a base branch
from

Conversation

yyassi-heartex
Copy link
Contributor

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

reducing relyance on toast.min.js to reduce the need for the extra file

@github-actions github-actions bot added the chore label Nov 5, 2024
Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 9b229b0
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/67360c6af22fed00081e2c8d

Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 9b229b0
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/67360c6a0ccd8c0008ba5a05

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.70%. Comparing base (92c85c5) to head (9b229b0).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6604   +/-   ##
========================================
  Coverage    76.70%   76.70%           
========================================
  Files          169      169           
  Lines        13846    13846           
========================================
  Hits         10621    10621           
  Misses        3225     3225           
Flag Coverage Δ
pytests 76.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luarmr
Copy link
Contributor

luarmr commented Nov 8, 2024

So cool!

Copy link
Collaborator

@hlomzik hlomzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's fix important typo

Copy link
Contributor

@bmartel bmartel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving BEM into the UI lib is opening the door for an antipattern we are actively moving away from. Let's remove that and just use standard SCSS means to migrate over. Any component that lands in the UI lib must be kept consistent.

@robot-ci-heartex
Copy link
Collaborator

Follow Merge downstream workflow has been failed.

Workflow run

@yyassi-heartex
Copy link
Contributor Author

yyassi-heartex commented Nov 13, 2024

/git merge develop

Workflow run
Successfully merged: 1 file changed, 22 insertions(+), 12 deletions(-)

@yyassi-heartex
Copy link
Contributor Author

yyassi-heartex commented Nov 13, 2024

/git merge develop

Workflow run
Successfully merged: Already up to date.

@yyassi-heartex yyassi-heartex marked this pull request as draft November 13, 2024 15:51
@yyassi-heartex yyassi-heartex marked this pull request as ready for review November 13, 2024 15:52
@vladimirheartex
Copy link
Contributor

vladimirheartex commented Nov 14, 2024

/git merge

Workflow run
Successfully merged: 16 files changed, 73 insertions(+), 54 deletions(-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants