-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: OPTIC-1313: Reducing Toast usage in django templates to get rid of toast.min.js #6604
base: develop
Are you sure you want to change the base?
Conversation
…d of toast.min.js
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6604 +/- ##
========================================
Coverage 76.70% 76.70%
========================================
Files 169 169
Lines 13846 13846
========================================
Hits 10621 10621
Misses 3225 3225
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
So cool! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's fix important typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving BEM into the UI lib is opening the door for an antipattern we are actively moving away from. Let's remove that and just use standard SCSS means to migrate over. Any component that lands in the UI lib must be kept consistent.
Follow Merge downstream workflow has been failed. |
/git merge develop
|
This reverts commit 276df55.
/git merge develop
|
/git merge
|
…label-studio into fb-optic-1313/toast-cleanup
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made
ex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
Change has impacts in these area(s)
(check all that apply)
Describe the reason for change
reducing relyance on toast.min.js to reduce the need for the extra file