Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: OPTIC-924: Remove Stale Feature Flag - ff_back_dev_2915_storage_nginx_proxy_26092022_short #6648

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

luarmr
Copy link
Contributor

@luarmr luarmr commented Nov 13, 2024

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

Remove long time stale feature flag

Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit b12b72c
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/6736a8a26a8a3300087bca20

Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit b12b72c
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/6736a8a24915500008879f33

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 76.71%. Comparing base (cf58e57) to head (b12b72c).
Report is 12 commits behind head on develop.

Files with missing lines Patch % Lines
label_studio/core/storage.py 0.00% 2 Missing ⚠️
label_studio/tasks/models.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6648      +/-   ##
===========================================
+ Coverage    76.68%   76.71%   +0.03%     
===========================================
  Files          169      169              
  Lines        13859    13848      -11     
===========================================
- Hits         10628    10624       -4     
+ Misses        3231     3224       -7     
Flag Coverage Δ
pytests 76.71% <25.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yyassi-heartex yyassi-heartex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh took me a second to see what happened in models - nice!

@luarmr
Copy link
Contributor Author

luarmr commented Nov 15, 2024

/git merge

Workflow run
Successfully merged: create mode 100644 web/apps/labelstudio/src/components/HeidiTips/hooks.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants