Skip to content

fix: allow deleting predictions with missing model version #9735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Snehadas2005 wants to merge 1 commit into
base: develop
Choose a base branch
from
+6 −4
Open

fix: allow deleting predictions with missing model version #9735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions label_studio/projects/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -883,9 +883,9 @@ def delete(self, request, *args, **kwargs):
project = self.get_object()
model_version = request.data.get('model_version', None)

if not model_version:
raise RestValidationError('model_version param is required')

if model_version == 'undefined' or model_version == 'null':
model_version = None
count = project.delete_predictions(model_version=model_version)

return Response(data=count)
Expand Down
4 changes: 3 additions & 1 deletion label_studio/projects/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -807,7 +807,9 @@ def delete_predictions(self, model_version=None):
"""
params = {'project': self}

if model_version:
if model_version is None or model_version == 'undefined':
params.update({'model_version__isnull': True})
else:
params.update({'model_version': model_version})

predictions = Prediction.objects.filter(**params)
Expand Down
Loading