Modify actionIds to depict the shiftInterval along with the button pressed. by DhritiKohli · Pull Request #250 · HuskieRobotics/SPOT

DhritiKohli · 2026-02-12T22:50:26Z

No description provided.

…ame.

Started to add the modified data transformers for /analysis to work

Finished debugging the weightedSumAverages

Copilot

Pull request overview

This pull request modifies the match scouting system to include shift interval information in action IDs. Instead of having static action IDs like "teleopShooting", actions are now dynamically prefixed with their game phase and shift number (e.g., "activeShift1Shooting", "inactiveShift2Passing", "endgameFall"). This enables more granular tracking and analysis of robot performance across different match phases and shifts.

Changes:

Modified action ID generation to dynamically prefix button IDs with camelCased phase/shift information from displayTextWithShift
Removed phase prefixes from button IDs in match-scouting.json (e.g., "autoShooting" → "Shooting") since prefixes are now added dynamically
Updated analysis pipeline and modules to work with the new shift-aware action ID format, including new sumAverage transformer for aggregating ratings across shifts
Enhanced countActions transformer to handle dynamic action IDs when counting all actions

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 22 comments.

Show a summary per file

File	Description
src/scouting/public/js/match-scouting.js	Implements dynamic action ID generation, shift tracking with counters, and camelCase utility function
src/analysis/transformers/countActions.js	Enhanced to handle dynamic action IDs by initializing counts with 0 or using defensive increment logic
src/analysis/transformers/sumAverage.js	New transformer for computing weighted averages across multiple rating groups (e.g., combining shift-specific ratings)
src/analysis/modules/Bar/index.js	Added default value of 0 to getPath call for safer data retrieval
config/match-scouting.json	Removed phase prefixes from button IDs, changed teleopActive/Inactive to "none" type, added climb highlighting executables
config/analysis-pipeline.json	Expanded rating calculations to include shift-specific paths and use sumAverage to aggregate across shifts
config/analysis-modules.json	Updated paths for endgame climb counts and fixed typo (averagesScores → averageScores)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-12T23:00:10Z

src/scouting/public/js/match-scouting.js

+  // NEW: shift counters
+  var activeShiftCount = 0;
+  var inactiveShiftCount = 0;
+  var currentShiftNumber;


The currentShiftNumber variable is declared but not initialized (line 23). It will be undefined until a shift button is pressed. When it's used in template literals at lines 311-312, this will result in strings like "Active Shift undefined" if the automatic shift switch happens before any manual button press. Initialize currentShiftNumber to 0 or handle the undefined case.

Suggested change

var currentShiftNumber;

var currentShiftNumber = 0;

Copilot · 2026-02-12T23:00:10Z

src/scouting/public/js/match-scouting.js

        lastActions[lastActions.length - 1].num++;
      }
    }
+    console.log(actionQueueIds);


This console.log statement appears to be debug code that should be removed before merging to production.

Suggested change

console.log(actionQueueIds);

Copilot · 2026-02-12T23:00:10Z

src/scouting/public/js/match-scouting.js

+          if (shiftButtonPressed && elapsedSinceSwitch >= shiftSwitchInterval) {
+            if (currentShift === "active") {
+              currentShift = "inactive";
+
+              inactiveShiftCount += 1;
+              currentShiftNumber = inactiveShiftCount;
+            } else {
+              currentShift = "active";
+              activeShiftCount += 1;
+              currentShiftNumber = activeShiftCount;
            }
+
+            lastShiftSwitchTime = time;
          }


The automatic shift switching logic has been changed to use Math.abs for calculating elapsedSinceSwitch, but there's no time range check anymore. Previously, the code checked "time < teleopTime && time > endgameTime" to ensure shifts only happen during teleop. Now shifts can potentially happen at any time as long as shiftButtonPressed is true and 25 seconds have elapsed. This could cause unintended shifts during autonomous or endgame periods. Restore the time range check to ensure shifts only occur during the teleop period.

Copilot · 2026-02-12T23:00:11Z

config/analysis-pipeline.json

+        "activeShift1stopShoot",
+        "activeShift2stopShoot",
+        "teleopTransitionstopShoot"


The actionId array includes "activeShift2stopShoot" but the corresponding pickup action is "activeShift2StartShoot" (capital S). This casing inconsistency will cause the cycle transformer to not properly match start and stop actions. All pickup and score action IDs should have consistent casing. The button ID in match-scouting.json is "StopShooting" which when combined with a shift prefix would create "activeShift2StopShooting", not "stopShoot". Verify that the actual button IDs match the expected action IDs in the pipeline.

Suggested change

"activeShift1stopShoot",

"activeShift2stopShoot",

"teleopTransitionstopShoot"

"activeShift1StopShoot",

"activeShift2StopShoot",

"teleopTransitionStopShoot"

Copilot · 2026-02-12T23:00:11Z

config/analysis-pipeline.json

+      ],
+      "scores": [
+        "activeShift1stopShoot",
+        "activeShift2stopShoot",


Same typo issue as line 82 - "activeShift2stopShoot" should likely be "activeShift2StopShoot" to match the expected button ID casing.

Suggested change

"activeShift2stopShoot",

"activeShift2StopShoot",

Copilot · 2026-02-12T23:00:14Z

config/match-scouting.json

          "gridArea": ["3", "7", "6", "12"],
          "class": "gray",
-          "type": "action",
+          "type": "none",


The button type has been changed from "action" to "none" for the teleopInactive button. However, the "none" button type still pushes an action to the actionQueue with temp: true (lines 138-143 in match-scouting.js). This means these actions will be filtered out before submission. If the intent is to track when shifts are manually selected, consider whether these should remain temporary actions or be permanent ones. If they should be temporary, the current implementation is correct but the naming "none" is misleading since it does create an action.

Suggested change

"type": "none",

"type": "action",

Copilot · 2026-02-12T23:00:14Z

config/analysis-pipeline.json

+      "scores": [
+        "activeShift1stopShoot",
+        "activeShift2stopShoot",
+        "teleopTransitionstopShoot"


Same typo issue - "teleopTransitionstopShoot" should likely be "teleopTransitionStopShoot" to match the expected button ID casing.

Suggested change

"teleopTransitionstopShoot"

"teleopTransitionStopShoot"

Copilot · 2026-02-12T23:00:15Z

config/match-scouting.json

        },
        {
-          "id": "endGameTowerRobot_Level2",
+          "id": "counts.l2",


The button ID was changed from "endGameTowerRobot_Level2" to "counts.l2". This appears to be setting the ID to a data path rather than an action identifier. Button IDs should be action identifiers (like "AttemptL2"), not data paths. This will cause issues when the action is recorded in the actionQueue and when trying to find this button for undo operations.

Suggested change

"id": "counts.l2",

"id": "endGameTowerRobot_Level2",

Copilot · 2026-02-12T23:00:15Z

config/match-scouting.json

        },
        {
-          "id": "counts.teleopFuelScored",
+          "id": "teleopFuelScored",


The button ID was changed from "counts.teleopFuelScored" to "teleopFuelScored". This change is in the opposite direction of the changes at lines 1018, 1026, and 1034. This inconsistency suggests confusion about whether IDs should include the "counts." prefix or not. Based on the codebase patterns, button IDs should be simple action identifiers without the "counts." prefix. The "counts." prefix is used in data paths, not action IDs. This change appears correct, but verify it's consistent with the overall design.

Copilot · 2026-02-12T23:00:15Z

src/analysis/transformers/sumAverage.js

+        throw new Error("sumAverage requires options.groups")
+    }
+
+    for (let [teamNumber, team] of Object.entries(dataset.teams)) {


Unused variable teamNumber.

Suggested change

for (let [teamNumber, team] of Object.entries(dataset.teams)) {

for (let team of Object.values(dataset.teams)) {

DhritiKohli added 10 commits February 5, 2026 09:21

got to display shifts with actionIDs

7332bd4

Merge branch 'main' into shift-assign

06e1e5c

Got the button.id be modified and show their timer interval for the s…

08d3829

…ame.

Added new pipelineTransformers

1a75bb2

Debug Analysis

51484e9

Started to add the modified data transformers for /analysis to work

Start Debugging timeInterval code

45ead74

Merge branch 'main' into shift-assign

cf26e55

Debug code + add sumAverage transformer.

ffebac9

Finished debugging the weightedSumAverages

Update analysis-pipeline to have inactiveshift rating avgs

d0c736a

Merge branch 'main' into shift-assign

259fc88

DhritiKohli requested a review from Copilot February 12, 2026 22:52

Copilot started reviewing on behalf of DhritiKohli February 12, 2026 22:52 View session

Copilot AI reviewed Feb 12, 2026

View reviewed changes

DhritiKohli and others added 5 commits February 14, 2026 10:35

Merge branch 'main' into shift-assign

ee51ec1

Update from Main and create new actionIds

3c46d9a

Change type from action to none

00ad910

update code

e801ed0

fixed auto and teleop shoot cycle times

904c5e2

DhritiKohli marked this pull request as ready for review February 14, 2026 19:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Modify actionIds to depict the shiftInterval along with the button pressed.#250

Modify actionIds to depict the shiftInterval along with the button pressed.#250
DhritiKohli wants to merge 15 commits intomainfrom
shift-assign

DhritiKohli commented Feb 12, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 12, 2026

Uh oh!

Copilot AI Feb 12, 2026

Uh oh!

Copilot AI Feb 12, 2026

Uh oh!

Copilot AI Feb 12, 2026

Uh oh!

Copilot AI Feb 12, 2026

Uh oh!

Copilot AI Feb 12, 2026

Uh oh!

Copilot AI Feb 12, 2026

Uh oh!

Copilot AI Feb 12, 2026

Uh oh!

Copilot AI Feb 12, 2026

Uh oh!

Copilot AI Feb 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	for (let [teamNumber, team] of Object.entries(dataset.teams)) {
	for (let team of Object.values(dataset.teams)) {

Conversation

DhritiKohli commented Feb 12, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants