Suggested change to xmltompc80col.py to add a "NET" line - #70
Open
emersonwhittaker1 wants to merge 4 commits into
Open
Suggested change to xmltompc80col.py to add a "NET" line#70emersonwhittaker1 wants to merge 4 commits into
emersonwhittaker1 wants to merge 4 commits into
Conversation
federicaspoto
self-requested a review
December 4, 2025 22:36
federicaspoto
left a comment
federicaspoto
left a comment
Contributor
There was a problem hiding this comment.
Hello @emersonwhittaker1 ,
thank you for working on this issue.
Could you please add a test to show that the change is actually working?
There is a tests folder.
Thanks!
Federica
Contributor
There was a problem hiding this comment.
Could you please remove this file?
Contributor
There was a problem hiding this comment.
Could you please remove this file?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I noticed that when converting from XML to 80 column format, the astrometry reduction catalog information is not added to the header as "NET". Here is my suggested change, which would add the first "astCat" entry as the "NET" value in the header. I know that this information may be redundant in the 80 column file, but I had been asked why I had omitted NET from my header and I discovered that this was the cause.
Best,
Emerson Whittaker