docker image for elasticsearch #39
Conversation
There was a problem hiding this comment.
Hi @lazloz92 -- thanks for contributing to this project. I made a few minor suggestions. I really like the idea of running elasticsearch in a container! If you're unable to address the comments, please let me know and I'll address them in another PR.
cc'ing @MLnick -- his review is definitely needed here
docker/elasticsearch/README.md
Outdated
| @@ -0,0 +1,5 @@ | |||
| #### 2.0 Start Elasticsearch with docker | |||
| If you familier with docker you can use the elasticsearch docker image with installed elasticsearch-vector-scoring plugin. | |||
There was a problem hiding this comment.
consider linking out to https://www.elastic.co/guide/en/elasticsearch/reference/current/docker.html for more info
docker/elasticsearch/README.md
Outdated
| #### 2.0 Start Elasticsearch with docker | ||
| If you familier with docker you can use the elasticsearch docker image with installed elasticsearch-vector-scoring plugin. | ||
| Just build the image with | ||
| ```docker build -t es-with-vector-scoring .``` |
There was a problem hiding this comment.
i think it'll be helpful to show the full output of both commands and state which directory to run them from
docker/elasticsearch/README.md
Outdated
| If you familier with docker you can use the elasticsearch docker image with installed elasticsearch-vector-scoring plugin. | ||
| Just build the image with | ||
| ```docker build -t es-with-vector-scoring .``` | ||
| and start the image with ```docker run -p 9200:9200 -p 9300:9300 es-with-vector-scoring``` |
There was a problem hiding this comment.
lastly, tell the user where to go back to, something like "Now that you've got Elasticsearch up and running, you can go back to step 3."
|
@stevemart thanks your help I modified the README based on your suggestions. Please let me know if I missed something. |
| FROM docker.elastic.co/elasticsearch/elasticsearch:5.3.0 | ||
|
|
||
| RUN /usr/share/elasticsearch/bin/elasticsearch-plugin install https://github.com/MLnick/elasticsearch-vector-scoring/releases/download/v5.3.0/elasticsearch-vector-scoring-5.3.0.zip | ||
| RUN \ |
There was a problem hiding this comment.
Why is this required? Is it a licensing issue?
| @@ -0,0 +1,29 @@ | |||
| #### 2.0 Start Elasticsearch with docker | |||
| If you familier with docker you can use the [elasticsearch docker image](https://www.elastic.co/guide/en/elasticsearch/reference/current/docker.html) with installed elasticsearch-vector-scoring plugin. | |||
| @@ -0,0 +1,29 @@ | |||
| #### 2.0 Start Elasticsearch with docker | |||
| If you familier with docker you can use the [elasticsearch docker image](https://www.elastic.co/guide/en/elasticsearch/reference/current/docker.html) with installed elasticsearch-vector-scoring plugin. | |||
There was a problem hiding this comment.
"... with the elasticsearch-vector-scoring plugin installed"
| @@ -0,0 +1,29 @@ | |||
| #### 2.0 Start Elasticsearch with docker | |||
| If you familier with docker you can use the [elasticsearch docker image](https://www.elastic.co/guide/en/elasticsearch/reference/current/docker.html) with installed elasticsearch-vector-scoring plugin. | |||
| Just go to docker/elasticsearch/ directory where you can find the ```Dockerfile``` and build the image with | |||
There was a problem hiding this comment.
Perhaps use single backticks for Dockerfile?
| ``` | ||
|
|
||
|
|
||
| If builds ended you can start the image with ```docker run -p 9200:9200 -p 9300:9300 es-with-vector-scoring``` command. |
There was a problem hiding this comment.
"Once the image has been built, run the image using the following command:"
| ... | ||
| ``` | ||
|
|
||
| Now that you've got Elasticsearch up and running, you can go back to step 2.2. |
There was a problem hiding this comment.
Provide a link back to the relevant section of the main README
| @@ -94,7 +99,7 @@ $ ./bin/elasticsearch | |||
| [2017-09-08T15:58:20,676][INFO ][o.e.n.Node ] initialized | |||
| ... | |||
| ``` | |||
|
|
|||
| #### 2.2 Elasticsearch python install | |||
There was a problem hiding this comment.
"Install the Elasticsearch Python client"
| This Code Pattern currently depends on Elasticsearch 5.3.0. | ||
|
|
||
| #### 2.1 Install Elasticsearch on your machine | ||
| (You can skip this if you want to use prepared docker image see: ./docker/elasticsearch/README.md) |
|
|
||
|
|
||
| If builds ended you can start the image with ```docker run -p 9200:9200 -p 9300:9300 es-with-vector-scoring``` command. | ||
| Check that the `elasticsearch-vector-scoring-plugin` is successfully loaded and elasticsearch is started: |
There was a problem hiding this comment.
Perhaps put "Elasticsearch is started" first, i.e. "Check that Elasticsearch has started and the ... "
I created a Dockerfile that install the vector plugin to elasticserch and create an image.