Include the return code only if Backend has no ReturnCode #103
Conversation
sameshai
changed the title
|
👍 Coverage increased from [%] to [74.04%] |
|
👍 Coverage increased from [%] to [74.07%] |
|
👍 Coverage increased from [%] to [74.27%] |
sameshai
force-pushed
the
errorcode
branch
5 times, most recently
from
7f286b9 to
a65f0eb
Compare
Signed-off-by: Sameer Shaikh <[email protected]>
|
👍 Coverage increased from [%] to [74.27%] |
|
👍 Coverage increased from [%] to [74.17%] |
|
👍 Coverage increased from [%] to [74.27%] |
Signed-off-by: Sameer Shaikh <[email protected]>
|
👍 Coverage increased from [%] to [74.27%] |
sameshai
changed the title
| expVol: nil, | ||
| subnetID: "sub-1", | ||
| securityGroupID: "kube-fake-cluster-id", | ||
| subnetError: nil, | ||
| securityGroupError: nil, | ||
| libVolumeResponse: nil, | ||
| libVolumeAccessPointError: nil, | ||
| libVolumeError: providerError.Message{Code: "FailedToPlaceOrder", Description: "Volume creation failed", Type: providerError.Unauthenticated}, | ||
| libVolumeError: providerError.Message{Code: "FailedToPlaceOrder", Description: "Volume creation failed", Type: providerError.Unauthenticated, RC: 400}, |
There was a problem hiding this comment.
Unauthenticated error looks to be not matching with error code codes.InvalidArgument
There was a problem hiding this comment.
IF we are expecting this then we need to match exact error codes and right if else conditions or similar logic. As of now for this phase anything that is not internal is 4xx invalid argument. We can discuss if required.
There was a problem hiding this comment.
We are considering 2 generic categories, 5xx server side error and 4xx client is not passing right parameters
https://github.ibm.com/alchemy-containers/armada-storage/issues/6171#issuecomment-1060167669 |
Signed-off-by: Sameer Shaikh <[email protected]>
|
👍 Coverage increased from [%] to [74.27%] |
Signed-off-by: Sameer Shaikh <[email protected]>
|
👍 Coverage increased from [%] to [74.04%] |
Signed-off-by: Sameer Shaikh <[email protected]>
|
👍 Coverage increased from [%] to [73.94%] |
Signed-off-by: Sameer Shaikh <[email protected]>
|
👍 Coverage increased from [%] to [73.92%] |
Signed-off-by: Sameer Shaikh <[email protected]>
Signed-off-by: Sameer Shaikh <[email protected]>
Signed-off-by: Sameer Shaikh <[email protected]>
Signed-off-by: Sameer Shaikh <[email protected]>
Signed-off-by: Sameer Shaikh <[email protected]>
Signed-off-by: Sameer Shaikh <[email protected]>
Signed-off-by: Sameer Shaikh <[email protected]>
Signed-off-by: Sameer Shaikh <[email protected]>
Signed-off-by: Sameer Shaikh <[email protected]>
|
👍 Coverage increased from [%] to [73.88%] |
No description provided.