-
Notifications
You must be signed in to change notification settings - Fork 0
#130 script to generate javacore collector for linux #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: sonalee-gupta <[email protected]>
javacoreCollector.sh
Outdated
@@ -0,0 +1,38 @@ | |||
#Copyright IBM Corp. 2025 - 2026 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copyright should be 2025-2025
javacoreCollector.sh
Outdated
# Validation | ||
if [[ -z "$libertyPath" && -z "$javaPid" ]]; then | ||
echo "Error: You must provide either 'libertyPath' or 'javaPid'." | ||
echo " ./javacoreCollector.sh libertyPath=/servers/clm" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The path should be like /opt/ibm/liberty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The patch looks good for me so far.
What needs to be done:
- Get an option for running the tool in liberty path
- Get parametrised $count and $interval
@sonaleegupta are you fine with further working on the patch? Let me know if you want to meet |
@kkazmierczyk yes, I'm on it. |
Signed-off-by: sonalee-gupta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the current changes look good. I think the next step would be to generate collector option for libery path. Here is how you need to run it:
export WLP_USER_DIR=/liberty
export JAVA_HOME=/server/jre
./liberty/wlp/bin/server javadump <server_name>
WLP_USER_DIR, JAVA_HOME and <server_name> should be configurable through the script.
Issue: 130
This PR contains javacoreCollector.sh linux script that accepts: