feat: migrate Gateways component from /gateways to /servers endpoint#4604
Open
vishu-bh wants to merge 2 commits intoepic/ui-rewritefrom
Open
feat: migrate Gateways component from /gateways to /servers endpoint#4604vishu-bh wants to merge 2 commits intoepic/ui-rewritefrom
vishu-bh wants to merge 2 commits intoepic/ui-rewritefrom
Conversation
- Refactor type hierarchy with BaseServer interface to eliminate duplication - Add VirtualServer interface with camelCase fields matching /servers response - Update Gateways.tsx to use /servers endpoint and VirtualServer type - Change field mappings: reachable→enabled, tool_count→associatedToolIds.length - Update timestamps to use camelCase: createdAt/updatedAt - Remove transport field from getServerTags (not in VirtualServer) - Fix unit tests to match new endpoint and response structure - Add comprehensive E2E test suite (18 tests, 30 passing, 1 skipped) - Update test expectations for new API structure Closes #<issue-number> Signed-off-by: Vishu Bhatnagar <vishu.bhatnagar@ibm.com>
vishu-bh
requested review from
a-effort and
marekdano
and removed request for
brian-hussey and
crivetimihai
- Remove unused 'page' parameter from skipped test in gateways.spec.ts - Replace 'any' types with 'Record<string, unknown>' in server.ts for metrics and oauthConfig fields Signed-off-by: Vishu Bhatnagar <vishu.bhatnagar@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates Gateways.tsx from legacy /gateways to new /servers endpoint with updated types, comprehensive tests, and new virtual servers listing UI.
Key Changes:
Test Results: 63 unit tests passing, 30 E2E tests passing (1 skipped)