Remove dead external log sink settings (elasticsearch, syslog, webhook)#5851
Open
pratyushsinghal7 wants to merge 1 commit into
Open
Remove dead external log sink settings (elasticsearch, syslog, webhook)#5851pratyushsinghal7 wants to merge 1 commit into
pratyushsinghal7 wants to merge 1 commit into
Conversation
Signed-off-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
pratyushsinghal7
requested review from
Lang-Akshay,
brian-hussey,
crivetimihai,
ja8zyjits and
msureshkumar88
as code owners
July 25, 2026 07:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
🔗 Related Issue
Part of #5848 (the three logging-sink flags; the remaining five flags need wiring up and are left for follow-ups)
📝 Summary
Removes the dead "External Log Integration" settings block from
mcpgateway/config.py—elasticsearch_enabled,syslog_enabled,webhook_logging_enabledand their companion fields (elasticsearch_url,elasticsearch_index_prefix,syslog_host,syslog_port,webhook_logging_urls). No code reads any of them, so setting e.g.ELASTICSEARCH_ENABLED=truesilently does nothing. Per #5848, removal is the right resolution for these three sinks (they look like never-implemented companions tostructured_logging_external_enabled).Also removes the corresponding entries from the Helm chart (
values.yaml,values.schema.json, chart README). They were not present in.env.example.docs/docs/design/images/classes.svgstill mentions them but is a generated diagram..secrets.baselinewas regenerated by the pre-commit hook (line-number shifts only).📏 Reviewability
triage🏷️ Type of Change
🧪 Verification
ruff check mcpgateway/config.pyyamllint -c .yamllint charts/mcp-stack/values.yamlpre-commit run(on changed files)grep -rnfor each removed name (snake_case and UPPER_CASE)classes.svgFull
make testwas not run locally (Windows dev box); relying on CI.✅ Checklist
make black isort pre-commit)