Skip to content

fix: SQLite-compatible DROP COLUMN in migration 6c0e5f8a9b1d downgrade #5874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jonpspri wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −3
Open

fix: SQLite-compatible DROP COLUMN in migration 6c0e5f8a9b1d downgrade #5874

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions mcpgateway/alembic/versions/6c0e5f8a9b1d_add_gateway_lifecycle_fields.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,12 @@ def downgrade() -> None:
if _index_exists(inspector, GATEWAY_TABLE, CLAIM_INDEX):
op.drop_index(CLAIM_INDEX, table_name=GATEWAY_TABLE)

# Use batch_alter_table for SQLite compatibility (SQLite < 3.35.0 doesn't support DROP COLUMN)
inspector = sa.inspect(bind)
columns = _column_names(inspector, GATEWAY_TABLE)
for column_name in reversed(LIFECYCLE_COLUMNS):
if column_name in columns:
op.drop_column(GATEWAY_TABLE, column_name)
columns_to_drop = [col for col in reversed(LIFECYCLE_COLUMNS) if col in columns]

if columns_to_drop:
with op.batch_alter_table(GATEWAY_TABLE, schema=None) as batch_op:
for column_name in columns_to_drop:
batch_op.drop_column(column_name)
Loading