Skip to content

fix(ui): use v1 API for global search - #6086

Merged
vishu-bh merged 1 commit into
epic/ui-rewritefrom
react-v1-global-search
Aug 5, 2026
Merged

fix(ui): use v1 API for global search#6086
vishu-bh merged 1 commit into
epic/ui-rewritefrom
react-v1-global-search

Conversation

@vishu-bh

@vishu-bh vishu-bh commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Pull Request

🔗 Related Issue

N/A


📝 Summary

Updates React global search to use the stable, versioned GET /v1/search API instead of the admin-only GET /admin/search endpoint.

Renames the client helper from searchAdminEntities to searchEntities and updates unit and Playwright coverage. Response handling remains unchanged because /v1/search provides the same grouped search contract while enforcing authentication, per-entity RBAC, and token scoping without requiring admin.dashboard.


📏 Reviewability

  • This PR has one clear purpose
  • The linked issue is not labeled triage
  • Unrelated bugs or improvements are tracked in separate issues/PRs
  • Tests are included with the code they validate

🏷️ Type of Change

  • Bug fix
  • Feature / Enhancement
  • Documentation
  • Refactor
  • Chore (deps, CI, tooling)
  • Other (describe below)

🧪 Verification

Check Command Status
Focused unit tests npm run test:run -- src/api/search.test.ts src/components/layout/HeaderQuickNav.test.tsx Passed (25 tests)
Targeted lint npx eslint src/api/search.ts src/api/search.test.ts src/components/layout/HeaderQuickNav.tsx src/components/layout/HeaderQuickNav.test.tsx e2e/global-search.spec.ts Passed
Formatting npx prettier --check src/api/search.ts src/api/search.test.ts src/components/layout/HeaderQuickNav.tsx src/components/layout/HeaderQuickNav.test.tsx e2e/global-search.spec.ts Passed
TypeScript npx tsc -b --pretty false Passed

✅ Checklist

  • Code formatted
  • Tests added/updated for changes
  • Documentation updated (not applicable)
  • No secrets or credentials committed

📓 Notes (optional)

Targets epic/ui-rewrite, where the React UI implementation lives.

Signed-off-by: Vishu Bhatnagar <vishu.bhatnagar@ibm.com>
@vishu-bh
vishu-bh marked this pull request as ready for review August 5, 2026 15:50

@gcgoncalves gcgoncalves left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@vishu-bh
vishu-bh merged commit a95c546 into epic/ui-rewrite Aug 5, 2026
7 checks passed
@vishu-bh
vishu-bh deleted the react-v1-global-search branch August 5, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants