Skip to content

fix: normalise auth_type spelling drift in mcp-catalog.yml - #6795

Open
OmmprakashMohanty01 wants to merge 1 commit into
IBM:mainfrom
OmmprakashMohanty01:fix/normalize-catalog-auth-type-values
Open

fix: normalise auth_type spelling drift in mcp-catalog.yml#6795
OmmprakashMohanty01 wants to merge 1 commit into
IBM:mainfrom
OmmprakashMohanty01:fix/normalize-catalog-auth-type-values

Conversation

@OmmprakashMohanty01

Copy link
Copy Markdown

🔗 Related Issue

Closes #6793


📝 Summary

Two entries in mcp-catalog.yml used non-canonical auth_type values that do not match the documented vocabulary (Open, OAuth2.1, API Key):

Entry Old value Correct value
customgpt (line 945) "API" "API Key"
instant (line 209) "OAuth" "OAuth2.1"

catalog_service.py:519 already treats "API" and "API Key" identically at registration, confirming these are the same type. These raw values are surfaced directly in the /v1/catalog auth_types facet, the legacy admin dropdown, and the new UI catalog filter — causing duplicate filter options to appear for the same conceptual auth type.

One intentional user-visible behaviour change: requests filtering on ?auth_type=API will no longer return the customgpt entry. Callers should use ?auth_type=API Key (the documented spec value).


📏 Reviewability

  • This PR has one clear purpose
  • The linked issue is not labeled triage
  • Unrelated bugs or improvements are tracked in separate issues/PRs
  • Tests are included with the code they validate
  • If AI-assisted, I understand and can explain the generated changes

🏷️ Type of Change

  • Bug fix

🧪 Verification

The change is a 2-line YAML value substitution. Verification:

# Before
grep 'auth_type:' mcp-catalog.yml | grep -v 'OAuth2\|API Key\|Open\|OAuth2.1 &'
# → auth_type: "API"     (customgpt, line 945)
# → auth_type: "OAuth"   (instant, line 209)

# After this PR — should return empty (no drift)
grep 'auth_type:' mcp-catalog.yml | grep -v 'OAuth2\|API Key\|Open\|OAuth2.1 &'
# → (empty — confirmed)
Check Command Status
No drift values remain grep auth_type mcp-catalog.yml | grep -v 'OAuth2|API Key|Open' ✅ Empty

✅ Checklist

  • Code formatted (YAML-only change, no Python formatting needed)
  • Tests added/updated for changes (no code path change — data correction only)
  • Documentation updated (if applicable) — N/A
  • No secrets or credentials committed

📓 Notes

This is a pure data correction — no Python code is changed. The fix aligns catalog data with the already-documented auth_type vocabulary and catalog_service.py's own normalisation logic.

@a-effort

Copy link
Copy Markdown
Collaborator

Thanks for contributing!

The DCO check is red: commit ff0762a has no Signed-off-by line. Since it's a single commit:

git commit --amend -s
git push --force-with-lease

The signoff address needs to match the commit author, otherwise the check stays failing.

Two catalog entries used non-canonical auth_type values that do not match
the documented vocabulary (Open, OAuth2.1, API Key):

  - customgpt:  "API"   → "API Key"   (line 945)
  - instant:    "OAuth" → "OAuth2.1"  (line 209)

catalog_service.py already treats "API" and "API Key" identically at
registration (line 519), confirming these are the same type. The raw
values are surfaced directly in the /v1/catalog auth_types facet, the
legacy admin dropdown, and the new UI catalog filter, causing duplicate
filter options to appear.

This change has one intentional user-visible effect: requests filtering
on ?auth_type=API will no longer match the customgpt entry; callers
should use ?auth_type=API Key instead (matching the documented spec).

Fixes IBM#6793

Signed-off-by: Ommprakash Mohanty <ommmohanty419@gmail.com>
@OmmprakashMohanty01
OmmprakashMohanty01 force-pushed the fix/normalize-catalog-auth-type-values branch from ff0762a to 7191edb Compare September 11, 2026 17:42
@OmmprakashMohanty01

Copy link
Copy Markdown
Author

Done — amended the commit with -s and force-pushed. The Signed-off-by: Ommprakash Mohanty <ommmohanty419@gmail.com> line is now in commit 7191edb. DCO check should go green shortly.

@marekdano marekdano left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OmmprakashMohanty01 - thanks for your contribution!
The PR changes look good!

LGTM 🚀

@marekdano marekdano self-assigned this Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][API]: Catalog auth_type values drift from the documented set

3 participants