fix: normalise auth_type spelling drift in mcp-catalog.yml - #6795
Open
OmmprakashMohanty01 wants to merge 1 commit into
Open
fix: normalise auth_type spelling drift in mcp-catalog.yml#6795OmmprakashMohanty01 wants to merge 1 commit into
OmmprakashMohanty01 wants to merge 1 commit into
Conversation
OmmprakashMohanty01
requested review from
Lang-Akshay,
brian-hussey,
crivetimihai,
ja8zyjits and
msureshkumar88
as code owners
September 11, 2026 17:14
Collaborator
|
Thanks for contributing! The DCO check is red: commit The signoff address needs to match the commit author, otherwise the check stays failing. |
a-effort
requested review from
gandhipratik203,
gcgoncalves,
marekdano and
vishu-bh
September 11, 2026 17:27
Two catalog entries used non-canonical auth_type values that do not match the documented vocabulary (Open, OAuth2.1, API Key): - customgpt: "API" → "API Key" (line 945) - instant: "OAuth" → "OAuth2.1" (line 209) catalog_service.py already treats "API" and "API Key" identically at registration (line 519), confirming these are the same type. The raw values are surfaced directly in the /v1/catalog auth_types facet, the legacy admin dropdown, and the new UI catalog filter, causing duplicate filter options to appear. This change has one intentional user-visible effect: requests filtering on ?auth_type=API will no longer match the customgpt entry; callers should use ?auth_type=API Key instead (matching the documented spec). Fixes IBM#6793 Signed-off-by: Ommprakash Mohanty <ommmohanty419@gmail.com>
OmmprakashMohanty01
force-pushed
the
fix/normalize-catalog-auth-type-values
branch
from
September 11, 2026 17:42
ff0762a to
7191edb
Compare
Author
|
Done — amended the commit with |
marekdano
approved these changes
Sep 14, 2026
marekdano
left a comment
Collaborator
There was a problem hiding this comment.
@OmmprakashMohanty01 - thanks for your contribution!
The PR changes look good!
LGTM 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Related Issue
Closes #6793
📝 Summary
Two entries in
mcp-catalog.ymlused non-canonicalauth_typevalues that do not match the documented vocabulary (Open, OAuth2.1, API Key):customgpt(line 945)"API""API Key"instant(line 209)"OAuth""OAuth2.1"catalog_service.py:519already treats"API"and"API Key"identically at registration, confirming these are the same type. These raw values are surfaced directly in the/v1/catalogauth_typesfacet, the legacy admin dropdown, and the new UI catalog filter — causing duplicate filter options to appear for the same conceptual auth type.One intentional user-visible behaviour change: requests filtering on
?auth_type=APIwill no longer return the customgpt entry. Callers should use?auth_type=API Key(the documented spec value).📏 Reviewability
triage🏷️ Type of Change
🧪 Verification
The change is a 2-line YAML value substitution. Verification:
grep auth_type mcp-catalog.yml | grep -v 'OAuth2|API Key|Open'✅ Checklist
📓 Notes
This is a pure data correction — no Python code is changed. The fix aligns catalog data with the already-documented auth_type vocabulary and
catalog_service.py's own normalisation logic.