Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable_checkpointing=False not possible #436

Closed
blumenstiel opened this issue Feb 19, 2025 · 2 comments · Fixed by #454
Closed

enable_checkpointing=False not possible #436

blumenstiel opened this issue Feb 19, 2025 · 2 comments · Fixed by #454
Assignees
Labels
0.99.9 bug Something isn't working

Comments

@blumenstiel
Copy link
Collaborator

Describe the issue
Setting enable_checkpointing: false is no possible because it leards to this error:

lightning.fabric.utilities.exceptions.MisconfigurationException: Trainer was configured with `enable_checkpointing=False` but found `ModelCheckpoint` in callbacks list.

This is because TerraTorch manually defines checkpoints.

Expected behavior (optional)
Handle checkpoints in a way that you can deacitvate it without manually overwriting ModelCheckpoint in the config.

@blumenstiel blumenstiel added bug Something isn't working 0.99.9 labels Feb 19, 2025
@Joao-L-S-Almeida Joao-L-S-Almeida self-assigned this Feb 24, 2025
@Joao-L-S-Almeida
Copy link
Member

@blumenstiel Let me know if the solution purposed in the PR linked to this issue is the enough.

@blumenstiel
Copy link
Collaborator Author

@Joao-L-S-Almeida Thanks for looking into it. I reviewed the pr, still needs some changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.99.9 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants