ModelCheckpoint must be defined in the config dict, not during the parsing.

[Joao-L-S-Almeida]

It should avoid the issue:

    raise MisconfigurationException(
lightning.fabric.utilities.exceptions.MisconfigurationException: Trainer was configured with `enable_checkpointing=False` but found `ModelCheckpoint` in callbacks list.

[romeokienzler]

@Joao-L-S-Almeida given @blumenstiel 's feedback, do you want to close this PR or merge it as an interim fix (which we can do, if we create an issue for the proper refactoring which we can push to v1.1 for example)

[blumenstiel]

@romeokienzler @Joao-L-S-Almeida With this fix, the user cannot overwirte the default settings. So I don't think you should merge it with the current code. At least, check if the user defines a checkpoint and only add if it is missing.
Also you need to test if the code is working if ModelCheckpoint is provided in the config, I would assume that is mailing because the argument is missing.

[Joao-L-S-Almeida]

Right. We can do it.

[Joao-L-S-Almeida]

@blumenstiel @romeokienzler I added it as part of the callbacks defined in the yaml file. When no callback is provided, but enable_checkpointing=True, the default config is used.

[Joao-L-S-Almeida]

The file tests/resources/configs/manufactured-finetune_prithvi_eo_v2_300.yaml was used for testing.

[blumenstiel]

Thanks @Joao-L-S-Almeida, looks good. @romeokienzler Can you have another look and test it?

[romeokienzler]

lgtm

[romeokienzler]

@blumenstiel seems your approval is needed as well

[romeokienzler]

lgtm

Benedikt indicated in the comments that he is fine with the changes