Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/mac local lambda #71

Merged
merged 5 commits into from
Aug 5, 2024
Merged

Fix/mac local lambda #71

merged 5 commits into from
Aug 5, 2024

Conversation

CarlosGomes98
Copy link
Contributor

@CarlosGomes98 CarlosGomes98 commented Aug 2, 2024 •
edited
Loading

  • Locally on mac, the previous unnamed lambda was not picklable, so tests were failing.
  • The assertion that there are no duplicates breaks previous configs (including one on hf) that use duplicates on dataset bands (e.g. -1 on all bands that are irrelevant). Removed that check for now

@Joao-L-S-Almeida
Copy link
Member

Feel free to merge.

@Joao-L-S-Almeida
Copy link
Member

I don't see any problem in using 'auto', since Lightning have successfully detected gpus when available. However, I believe that setting 'cpu' is less error prone.

@Joao-L-S-Almeida Joao-L-S-Almeida merged commit 7eb432d into main Aug 5, 2024
3 checks passed
@CarlosGomes98 CarlosGomes98 deleted the fix/mac_local_lambda branch October 2, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Joao-L-S-Almeida Joao-L-S-Almeida Joao-L-S-Almeida approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CarlosGomes98 @Joao-L-S-Almeida