Make api_key_env_var optional in LoadFromAPI #1799
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martín Santillán Cooper <[email protected]>
martinscooper
force-pushed
the
LoadFromAPI-optional-apikey
branch
from
cd60334 to
20bbbf7
Compare
|
@perlitz will this new default break any of the sql pipelines? |
|
I'll make sure it doesn't |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the docstring states,
api_key_env_varshould be optional:Currently, it has a default value of
SQL_API_KEY, forcing users to set that env var even if the endpoint doesn't require any api key.This PR makes
api_key_env_varoptional.