Draft
Conversation
oerc0122
added
enhancement
oerc0122
force-pushed
the
descriptors
branch
8 times, most recently
from
d192297 to
e14f9b5
Compare
oerc0122
force-pushed
the
descriptors
branch
7 times, most recently
from
f85e6f3 to
c3f866b
Compare
oerc0122
force-pushed
the
descriptors
branch
2 times, most recently
from
de79234 to
e2d8402
Compare
oerc0122
force-pushed
the
descriptors
branch
3 times, most recently
from
6107d51 to
218cfdc
Compare
oerc0122
force-pushed
the
descriptors
branch
5 times, most recently
from
5233370 to
4c36581
Compare
oerc0122
force-pushed
the
descriptors
branch
2 times, most recently
from
316fceb to
ffecac6
Compare
oerc0122
force-pushed
the
descriptors
branch
2 times, most recently
from
0b02b12 to
48a14f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of work
Complete rework of MDANSE infrastructure to replace parameter dictionaries with
descriptorParameters with validators.Fixes
To test
This is a complete rework and will require significant and thorough testing.