Replace SubclassFactory with a RegisterFactory#1072
Open
oerc0122 wants to merge 11 commits intoISISNeutronMuon:protosfrom
Open
Replace SubclassFactory with a RegisterFactory#1072oerc0122 wants to merge 11 commits intoISISNeutronMuon:protosfrom
oerc0122 wants to merge 11 commits intoISISNeutronMuon:protosfrom
Conversation
48272be to
4786078
Compare
Collaborator
4786078 to
3fdd4c4
Compare
3fdd4c4 to
4d27b72
Compare
4d27b72 to
1344564
Compare
1344564 to
b133a07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description of work
SubclassFactorywith a classicRegisterFactoryto avoid metaclass magic, allow effective ABCs and explicit inclusion (i.e. not includingConverteras anIJoband thus making a non-instantiable object a key) and naming (including multiple names for the same thing).UCDictclass for case-insensitive dictionary keys.DummyIJobchild to account forABCworking properly.PR is broken down since it is a large number of files touched (though small changes):
SubclassFactoryNB. Converters are registered in both IJob and Converter as was historical.
Fixes
Part of the motivation for this is to support a factory-like mechanism for GUI Widgets from Descriptor types.
To test
Standard tests should run.