Draft
Conversation
oerc0122
force-pushed
the
qvectors-rework
branch
from
ba2870d to
b7c8521
Compare
oerc0122
commented
Mar 18, 2025
| """ | ||
| return recursive_dict(cls) | ||
|
|
||
| class RegisterFactory(ABC, Generic[T]): |
Collaborator
Author
There was a problem hiding this comment.
This can be broken out into a separate PR if we prefer.
oerc0122
force-pushed
the
qvectors-rework
branch
4 times, most recently
from
3f52f3f to
58e7618
Compare
Collaborator
|
Would you agree that the main reason for the RegisterFactory class is to register the subclasses explicitly and not automatically? |
Collaborator
Author
Yeah, it also means you can have multiple aliases (if desired) and you can have more than one class per file allowing sensible grouping. Scanning files is not terribly safe and also means that it's picking up temporary files from my editor. |
Collaborator
oerc0122
force-pushed
the
qvectors-rework
branch
from
a3535b9 to
7393386
Compare
oerc0122
force-pushed
the
qvectors-rework
branch
2 times, most recently
from
0a2cf2b to
c0aeae9
Compare
oerc0122
force-pushed
the
qvectors-rework
branch
2 times, most recently
from
c6d85b5 to
9406898
Compare
oerc0122
force-pushed
the
qvectors-rework
branch
3 times, most recently
from
119d54f to
079fe22
Compare
oerc0122
force-pushed
the
qvectors-rework
branch
2 times, most recently
from
62a8611 to
338fe38
Compare
oerc0122
force-pushed
the
qvectors-rework
branch
3 times, most recently
from
bd8b995 to
87af74c
Compare
- Start building VectorList
oerc0122
force-pushed
the
qvectors-rework
branch
from
87af74c to
f142f95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of work
Implement independent new scheme for handling Q-Vectors without shells.
Fixes
Fixes #656
Fixes #458
Fixes #446
Fixes #705
To test
New tests in UnitTests/NewQVectors